Add builtInZoomControls for Android#5
Conversation
added to gitignore
|
Thanks for the pull request! Can you attach a screenshot? |
|
Zoom controls enable zooming and appear when you move content or zoom in with your fingers. They disappear a few seconds after no longer having interaction.
|
|
Looks great! Thanks for the contribution. I'd prefer to keep this change only related to the functionality provided. If you can eliminate changes to |
… alarmas. Corregido el problema de mapas en android viejos
…material 3. Nuevo Branch
… y flutter mas nuevo.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the asset_webview Flutter plugin to support newer versions of Flutter, Dart, Android, and Kotlin, while adding zoom control functionality and improving URL handling.
- Updates minimum Dart SDK from 2.17.0 to 3.3.0 and Flutter from 3.0.0 to 3.19.0
- Adds built-in zoom controls feature for WebView
- Enhances URL loading behavior to handle http/https URLs by opening them in external browser
Reviewed Changes
Copilot reviewed 11 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Updates minimum Dart SDK to 3.3.0 and Flutter to 3.19.0 |
| pubspec.lock | Removes lockfile (now gitignored) |
| lib/asset_webview.dart | Adds builtInZoomControls parameter and reorders imports |
| example/pubspec.yaml | Updates SDK constraints and cupertino_icons version |
| example/pubspec.lock | Removes lockfile (now gitignored) |
| example/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle from 6.7 to 7.6.3 |
| example/android/build.gradle | Removes buildscript block (modernized configuration) |
| asset_webview.iml | Removes IDE configuration file (now gitignored) |
| android/src/main/kotlin/com/greensopinion/flutter/asset_webview/AssetWebview.kt | Adds zoom controls, implements deprecated shouldOverrideUrlLoading, and adds http/https URL handling |
| android/src/main/AndroidManifest.xml | Removes package attribute (migrates to namespace in build.gradle) |
| android/gradle/wrapper/gradle-wrapper.properties | Removes Gradle wrapper properties |
| android/gradle.properties | Removes gradle properties file |
| android/build.gradle | Updates Kotlin to 2.2.21, Gradle plugin to 8.13.0, SDK to 36, Java to 17, and minimum SDK to 23 |
| .idea/workspace.xml | Removes IDE workspace file (now gitignored) |
| .idea/runConfigurations/example_lib_main_dart.xml | Removes IDE run configuration (now gitignored) |
| .idea/modules.xml | Removes IDE modules configuration (now gitignored) |
| .idea/libraries/Dart_SDK.xml | Removes IDE library configuration (now gitignored) |
| .gitignore | Adds .idea/, *.iml, and pubspec.lock to gitignore |
Files not reviewed (4)
- .idea/libraries/Dart_SDK.xml: Language not supported
- .idea/modules.xml: Language not supported
- .idea/runConfigurations/example_lib_main_dart.xml: Language not supported
- .idea/workspace.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| } | ||
| ) | ||
| // can't block here, so we ovreride all requests and then later apply the response |
There was a problem hiding this comment.
Corrected spelling of 'ovreride' to 'override'.
|
|
||
| kotlinOptions { | ||
| jvmTarget = '1.8' | ||
| jvmTarget = JavaVersion.VERSION_17 |
There was a problem hiding this comment.
jvmTarget expects a String value, not a JavaVersion constant. This should be jvmTarget = '17' to match the format expected by kotlinOptions.
| jvmTarget = JavaVersion.VERSION_17 | |
| jvmTarget = '17' |
The built-in zoom mechanisms comprise on-screen zoom controls, which are displayed over the WebView's content, and the use of a pinch gesture to control zooming.
iOS webview has zoom controls integrated by default.