Open
Conversation
This was causing a segfault when getting trash targets with details. I think nobody uses this, because it's been like this since 2012. The other cases already do the quoting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Quote the keyword
endin the SQL ininit_port_range_iterator.See L2166 and L2176 above where the exact same quoting is already done.
Why
This was causing a segfault when getting trash targets with details.
I think nobody uses this case (trash targets with details), because the quoting has been missing since 2012.
Testing
Before this would have an empty response, with a segv showing in the logs.