Fix: remove old transaction functions#2761
Merged
greenbonebot merged 2 commits intomainfrom Feb 10, 2026
Merged
Conversation
This can be safely removed because it required in_transaction to be true, which required manage_transaction_start. These transaction functions were last used by the OTP handling, which was removed in 558e957.
bjoernricks
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
manage_transaction_startandmanage_transaction_stop.Why
These transaction functions were last used by the OTP handling, which was removed in 558e957.
This is part of reducing the size of
manage_sql.c.References
Follows /pull/2759.
Testing
Compiles, tests pass, modifying target works.