Change: move more functions to dedicated permissions files#2740
Merged
greenbonebot merged 3 commits intomainfrom Jan 29, 2026
Merged
Change: move more functions to dedicated permissions files#2740greenbonebot merged 3 commits intomainfrom
greenbonebot merged 3 commits intomainfrom
Conversation
Required a tiny code change: add_feed_role_permissions calls manage_resource_name(...) instead of the equivalent resource_name(... LOCATION_TABLE).
bjoernricks
force-pushed
the
perm-files-2
branch
from
982e09a to
64c4d24
Compare
bjoernricks
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move more permission functions out of
manage_sql.c.Why
Reducing the size of
manage_sql.c. More consistent file organisation.References
Follows /pull/2737
Testing
I ran GET_PERMISSIONs and compared the output with main and the PR:
Also ran with the --optimize options.