Open
Conversation
The hosts ordering option has never been used, so it is removed from the sources.
bjoernricks
reviewed
Jan 22, 2026
Contributor
bjoernricks
left a comment
bjoernricks
left a comment
There was a problem hiding this comment.
Is it still possible for a GMP client to include <hosts_ordering> in the request without gvmd returning an error? otherwise we need to increase the GMP major version because it breaks our API.
bjoernricks
reviewed
Jan 30, 2026
Contributor
bjoernricks
left a comment
bjoernricks
left a comment
There was a problem hiding this comment.
Looks good to me but a gvmd dev should take another look just to be sure :-)
mattmundell
requested changes
Feb 10, 2026
| gvm_append_string (&modify_task_data->comment, ""); | ||
| set_client_state (CLIENT_MODIFY_TASK_COMMENT); | ||
| } | ||
| /* HOSTS_ORDERING kept for reasons of compatibility */ |
Contributor
There was a problem hiding this comment.
I'd prefer if these were removed.
GMP will just "read over" any foreign elements. See the ELSE_READ_OVER that's everywhere in gmp.c, and the set_read_over at the end of gmp_xml_handle_start_element.
For example, if you run this the comments is still modified:
o m m '<modify_task task_id="8831937d-0e87-439a-807c-a9a2cf976f6a"><random_element>abc</random_element><comment>123</comment></modify_task>'| * @return 0 success, -1 error. | ||
| */ | ||
| int | ||
| migrate_266_to_267 () |
Contributor
There was a problem hiding this comment.
This number is used now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The hosts ordering option has never been used, so it has been removed from the sources.
Why
The hosts ordering option was never used.
References
GEA-1499
Checklist
Tested manually on my local development system.