Skip to content

Comments

Change: move first few role functions to dedicated files#2697

Merged
greenbonebot merged 1 commit intomainfrom
roles-files-1
Jan 5, 2026
Merged

Change: move first few role functions to dedicated files#2697
greenbonebot merged 1 commit intomainfrom
roles-files-1

Conversation

@mattmundell
Copy link
Contributor

What

Move first few functions out of the Roles section of manage_sql.c.

Why

Reduces the size of manage_sql.c to make it easier to work with. Also for better organization of the resources.

References

Similar to #2694 for Groups.

Testing

I ran gvmd --get-roles. Looked OK.

I also ran GET_GROUPS, comparing the output to main:

# on main
o m m '<get_roles/>' > /tmp/r-main
o m m '<get_roles trash="1"/>' > /tmp/r-main-trash
# with pr
o m m '<get_roles/>' > /tmp/r-pr
o m m '<get_roles trash="1"/>' > /tmp/r-pr-trash
diff /tmp/r-main /tmp/r-pr
diff /tmp

@mattmundell mattmundell requested review from a team as code owners January 1, 2026 18:04
@greenbonebot greenbonebot enabled auto-merge (rebase) January 1, 2026 18:04
@greenbonebot greenbonebot merged commit 5fad8f5 into main Jan 5, 2026
29 of 30 checks passed
@greenbonebot greenbonebot deleted the roles-files-1 branch January 5, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants