Skip to content

Change: move delete_group to group files #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenbonebot merged 1 commit into from
Dec 22, 2025
Merged

Change: move delete_group to group files #2691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/manage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2869,9 +2869,6 @@ set_schedule_timeout (int);
int
init_group_iterator (iterator_t *, get_data_t *);

int
delete_group (const char *, int);

gchar *
group_users (group_t);

Expand Down
3 changes: 3 additions & 0 deletions src/manage_groups.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,7 @@ group_writable (group_t);
int
create_group (const char *, const char *, const char *, int, group_t *);

int
delete_group (const char *, int);

#endif /* not _GVMD_MANAGE_GROUPS_H */
172 changes: 2 additions & 170 deletions src/manage_sql.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,6 @@ user_ensure_in_db (const gchar *, const gchar *);
static int
set_password (const gchar *, const gchar *, const gchar *, gchar **);

static void
permissions_set_subjects (const char *, resource_t, resource_t, int);

static resource_t
permission_resource (permission_t);

Expand Down Expand Up @@ -265,9 +262,6 @@ permission_name (permission_t);
static void
cache_permissions_for_resource (const char *, resource_t, GArray*);

static void
cache_all_permissions_for_users (GArray*);

static void
report_cache_counts (report_t, int, int, const char*);

Expand Down Expand Up @@ -33040,168 +33034,6 @@ modify_schedule (const char *schedule_id, const char *name, const char *comment,

/* Groups. */

/**
* @brief Delete a group.
*
* @param[in] group_id UUID of group.
* @param[in] ultimate Whether to remove entirely, or to trashcan.
*
* @return 0 success, 1 fail because a permission refers to the group, 2 failed
* to find group, 3 predefined group, 99 permission denied, -1 error.
*/
int
delete_group (const char *group_id, int ultimate)
{
group_t group = 0;
GArray *affected_users;
iterator_t users_iter;

sql_begin_immediate ();

if (acl_user_may ("delete_group") == 0)
{
sql_rollback ();
return 99;
}

if (find_group_with_permission (group_id, &group, "delete_group"))
{
sql_rollback ();
return -1;
}

if (group == 0)
{
if (find_trash ("group", group_id, &group))
{
sql_rollback ();
return -1;
}
if (group == 0)
{
sql_rollback ();
return 2;
}
if (ultimate == 0)
{
/* It's already in the trashcan. */
sql_commit ();
return 0;
}

if (trash_group_in_use (group))
{
sql_rollback ();
return 1;
}

sql ("DELETE FROM permissions"
" WHERE resource_type = 'group'"
" AND resource = %llu"
" AND resource_location = " G_STRINGIFY (LOCATION_TRASH) ";",
group);
sql ("DELETE FROM permissions_trash"
" WHERE resource_type = 'group'"
" AND resource = %llu"
" AND resource_location = " G_STRINGIFY (LOCATION_TRASH) ";",
group);
sql ("DELETE FROM permissions"
" WHERE subject_type = 'group'"
" AND subject = %llu"
" AND subject_location = " G_STRINGIFY (LOCATION_TRASH) ";",
group);
sql ("DELETE FROM permissions_trash"
" WHERE subject_type = 'group'"
" AND subject = %llu"
" AND subject_location = " G_STRINGIFY (LOCATION_TRASH) ";",
group);

tags_remove_resource ("group", group, LOCATION_TRASH);

sql ("DELETE FROM group_users_trash WHERE \"group\" = %llu;", group);
sql ("DELETE FROM groups_trash WHERE id = %llu;", group);
sql_commit ();
return 0;
}

if (group_in_use (group))
{
sql_rollback ();
return 1;
}

if (ultimate == 0)
{
group_t trash_group;

sql ("INSERT INTO groups_trash"
" (uuid, owner, name, comment, creation_time, modification_time)"
" SELECT uuid, owner, name, comment, creation_time,"
" modification_time"
" FROM groups WHERE id = %llu;",
group);

trash_group = sql_last_insert_id ();

sql ("INSERT INTO group_users_trash"
" (\"group\", \"user\")"
" SELECT %llu, \"user\""
" FROM group_users WHERE \"group\" = %llu;",
trash_group,
group);

permissions_set_locations ("group", group, trash_group, LOCATION_TRASH);
tags_set_locations ("group", group, trash_group, LOCATION_TRASH);
permissions_set_subjects ("group", group, trash_group, LOCATION_TRASH);
}
else
{
sql ("DELETE FROM permissions"
" WHERE resource_type = 'group'"
" AND resource = %llu"
" AND resource_location = " G_STRINGIFY (LOCATION_TRASH) ";",
group);
sql ("DELETE FROM permissions_trash"
" WHERE resource_type = 'group'"
" AND resource = %llu"
" AND resource_location = " G_STRINGIFY (LOCATION_TRASH) ";",
group);
sql ("DELETE FROM permissions"
" WHERE subject_type = 'group'"
" AND subject = %llu"
" AND subject_location = " G_STRINGIFY (LOCATION_TABLE) ";",
group);
sql ("DELETE FROM permissions_trash"
" WHERE subject_type = 'group'"
" AND subject = %llu"
" AND subject_location = " G_STRINGIFY (LOCATION_TABLE) ";",
group);
}

tags_remove_resource ("group", group, LOCATION_TABLE);

affected_users = g_array_new (TRUE, TRUE, sizeof (user_t));
init_iterator (&users_iter,
"SELECT \"user\" FROM group_users"
" WHERE \"group\" = %llu",
group);
while (next (&users_iter))
{
user_t user = iterator_int64 (&users_iter, 0);
g_array_append_val (affected_users, user);
}
cleanup_iterator (&users_iter);

sql ("DELETE FROM group_users WHERE \"group\" = %llu;", group);
sql ("DELETE FROM groups WHERE id = %llu;", group);

cache_all_permissions_for_users (affected_users);
g_array_free (affected_users, TRUE);

sql_commit ();
return 0;
}

/**
* @brief Gets users of group as a string.
*
Expand Down Expand Up @@ -33493,7 +33325,7 @@ permissions_set_orphans (const char *type, resource_t resource, int location)
* @param[in] new Resource ID in new table.
* @param[in] to Destination, trash or table.
*/
static void
void
permissions_set_subjects (const char *type, resource_t old, resource_t new,
int to)
{
Expand Down Expand Up @@ -44429,7 +44261,7 @@ cache_permissions_for_users (const char *type, GArray *cache_users)
* @param[in] cache_users GArray of users to create cache for. NULL means
* all users.
*/
static void
void
cache_all_permissions_for_users (GArray *cache_users)
{
int free_users;
Expand Down
6 changes: 6 additions & 0 deletions src/manage_sql.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,12 @@ permissions_set_locations (const char *, resource_t, resource_t, int);
void
permissions_set_orphans (const char *, resource_t, int);

void
permissions_set_subjects (const char *, resource_t, resource_t, int);

void
cache_all_permissions_for_users (GArray *);

int
copy_resource (const char *, const char *, const char *, const char *,
const char *, int, resource_t *, resource_t *);
Expand Down
Loading
Loading