Fix: add const to tmp in parse_port_of_addr#1052
Merged
greenbonebot merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This is required because addr is const and addr is being assigned to tmp via strrchr. As a result parse_port_of_addr also needs to return a const, and the test vars need to be const.
mattmundell
force-pushed
the
parse-port-const
branch
from
537cfa0 to
9fd068d
Compare
bjoernricks
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
consttotmpin port parsing in kb.cWhy
This is required because addr is const and addr is being assigned to tmp via strrchr.
As a result
parse_port_of_addralso needs to return a const, and the test vars need to be const.References
Closes #1051.