feat: Replace Agent Installers page with Agent Install Instructions page#5124
feat: Replace Agent Installers page with Agent Install Instructions page#5124bjoernricks merged 3 commits intomainfrom
Conversation
Replace the agent-installers download page with a new Install Instructions page that fetches and displays installation instructions from the agent-controller API. The page supports: - Multi-language (uses current GSA language setting) - Multiple agent controllers (dropdown when more than one available) - Dynamic content from agent-controller's install-instructions endpoint - Copy-to-clipboard functionality for code blocks
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Pull request overview
Replaces the existing “Agent Installers” download route with a new “Agent Install Instructions” page that pulls HTML installation instructions from the agent-controller API (with language support, controller selection, and copy-to-clipboard behavior).
Changes:
- Added
AgentInstallInstructionsPagethat discovers agent-controller scanners, fetches install instructions HTML, and renders it. - Added controller selection UI when multiple controllers are available.
- Updated routing so
/agent-installersnow loads the new instructions page.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/web/pages/agent-remote-installer/AgentInstallInstructionsPage.tsx |
New page: fetch controllers + install instructions HTML, render instructions, add copy handling. |
src/web/Routes.tsx |
Routes /agent-installers to the new instructions page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/web/pages/agent-remote-installer/AgentInstallInstructionsPage.tsx
Outdated
Show resolved
Hide resolved
src/web/pages/agent-remote-installer/AgentInstallInstructionsPage.tsx
Outdated
Show resolved
Hide resolved
src/web/pages/agent-remote-installer/AgentInstallInstructionsPage.tsx
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5124 +/- ##
=======================================
Coverage 77.04% 77.04%
=======================================
Files 1170 1170
Lines 30492 30492
Branches 9120 9120
=======================================
Hits 23494 23494
Misses 6258 6258
Partials 740 740 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not sure how co-pilot got activated for review :-/ |
Not by me .... |
Integrate DOMPurify to sanitize dynamically fetched agent installation instructions, improving security against XSS attacks. Additionally: - Enhanced the `Agent Install Instructions` page with better error handling and safety measures. - Introduced language-specific support for "Copy" and "Copied!" buttons. - Refactored and improved loading logic when changing agent controllers or languages.
bjoernricks
left a comment
There was a problem hiding this comment.
Hi, i have serious doubts of this "feature" first of all this hasn't been discussed beforehand were we could have talked about the details in possible solutions. Just dropping the current agent install page with something else is a bit frustration on my side.
But also I have a major concern with loading some HTML content from an URL that is out of the control of the GEA team and having to maintain this interface. I would be ok if that URL is returning static string content but HTML is a no-go for me in the current situation. If you need html content it should be implemented at the GSA in react with styled-components for styling. If that isn't possible we could also add links for opening a new page with installation instructions externally.
Rebase failed
Replace the agent-installers download page with a new Install Instructions page that fetches and displays installation instructions from the agent-controller API. The page supports: