Skip to content

refactor: move filter definition endpoint under observability#16392

Merged
a-cordier merged 1 commit intomasterfrom
apim-12117-filter-definition
Apr 15, 2026
Merged

refactor: move filter definition endpoint under observability#16392
a-cordier merged 1 commit intomasterfrom
apim-12117-filter-definition

Conversation

@a-cordier
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the log filter definition system into a unified observability filters framework, replacing the /logs/definition/filters endpoint with /observability/filters/definition. The changes involve migrating use cases to the analytics engine and removing obsolete log-specific definitions and services. Feedback indicates a potential regression where the IN operator for the HTTP_STATUS filter was removed, which may impact users who filter by multiple status codes.

@a-cordier a-cordier marked this pull request as ready for review April 14, 2026 13:52
@a-cordier a-cordier requested a review from a team as a code owner April 14, 2026 13:52
@a-cordier a-cordier force-pushed the apim-12117-filter-definition branch from 0378cde to c38c04a Compare April 14, 2026 15:11
@a-cordier a-cordier merged commit 29e6247 into master Apr 15, 2026
14 checks passed
@a-cordier a-cordier deleted the apim-12117-filter-definition branch April 15, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants