[master] fix: remove subscription end-date check against client certificate#16342
Merged
JedrzejJanasiak merged 1 commit intomasterfrom Apr 16, 2026
Merged
[master] fix: remove subscription end-date check against client certificate#16342JedrzejJanasiak merged 1 commit intomasterfrom
JedrzejJanasiak merged 1 commit intomasterfrom
Conversation
Remove the validation that prevented a subscription end date from falling after the client certificate expiry. Per GKO-2519, certificate timeline management is now the application owner's responsibility and broken timelines are explicitly allowed. Both throw sites are removed (SubscriptionValidationServiceImpl.validateTls and ApplicationServiceImpl.syncClientCertificates), along with the SubscriptionEndsAfterClientCertificateException itself. GKO-2788 (cherry picked from commit fdd6fef)
JedrzejJanasiak
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic copy of pull request #16326 done by Mergify.
Issue
Description
SubscriptionEndsAfterClientCertificateExceptionwhen a subscription end date fell after the client certificate expiry.SubscriptionValidationServiceImpl.validateTls()andApplicationServiceImpl.syncClientCertificates().SubscriptionEndsAfterClientCertificateExceptionclass itself is deleted (no more references).