Merged
Conversation
Needed a fast and easy way to generate docker images for my pi3b, without setting up a build environment on the pi itself. Also didn't want the hassle of QEMU, så used github actions instead. To make images, I use the fact that they're created when using the github actions module "docker/build-push-action@v5". Added various optional input to control the build and tried to make it future proof, by having it detect supported architectures and node versions from the source code and from the availability of both base images and packages. Incidentally that also causes the workflow to be able to build older versions of pigallery2. I have done a few pin point tests since they are good test material. Had success with several versions.
Pull Request Test Coverage Report for Build 20757118838Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed a fast and easy way to generate docker images for my pi3b, without setting up a build environment on the pi itself. Also didn't want the hassle of QEMU, så used github actions instead. To make images, I use the fact that they're created when using the github actions module "docker/build-push-action@v5".
Added various optional input to control the build and tried to make it future proof, by having it detect supported architectures and node versions from the source code and from the availability of both base images and packages.
Incidentally that also causes the workflow to be able to build older versions of pigallery2. I have done a few pin point tests since they are good test material. Had success with several versions.