Fix sync errors as mentioned in #15 #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2021 10:19
…ymbol to try_getUnderlyingPrice, try_name, try_symbol...etc
|
Hey @cwang25, thanks for the extra code fixes! I'll be merging my fix first, since the deployment for that fix is already synced on the hosted service (and it should automatically and instantly fix the official subgraph), but after merging that one I'll review your code and most likely merge that too, so it starts syncing in parallel to fix any further issues :) |
Author
|
No problem. Happy to help :) I have also quick-fixed the merge conflict, this PR is good to merge anytime. |
l1negreen21
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15. Changes the uses of getUnderlyingPrice, name, symbol to try_getUnderlyingPrice, try_name, try_symbol...etc
Current subgraph is stuck at Block 12,996,808
By add try_ to those functions, it would be able to sync to the head just fine.
