Skip to content

Conversation

@granluo
Copy link
Owner

@granluo granluo commented Nov 23, 2020

No description provided.

@granluo
Copy link
Owner Author

granluo commented Nov 23, 2020

Nightly Testing Report

Failures are detected in workflow(s)
This issue is generated at 11/23/2020 15:29 PM

Workflow 11/22
release failure
prerelease failure
mlmodeldownloader failure

1 similar comment
@granluo
Copy link
Owner Author

granluo commented Nov 23, 2020

Nightly Testing Report

Failures are detected in workflow(s)
This issue is generated at 11/23/2020 15:29 PM

Workflow 11/22
release failure
prerelease failure
mlmodeldownloader failure

@granluo
Copy link
Owner Author

granluo commented Nov 23, 2020

Nightly Testing Report

Failures are detected in workflow(s)
This issue is generated at 11/23/2020 14:41 PM

Workflow 11/22
release failure
prerelease failure
mlmodeldownloader failure

1 similar comment
@granluo
Copy link
Owner Author

granluo commented Nov 23, 2020

Nightly Testing Report

Failures are detected in workflow(s)
This issue is generated at 11/23/2020 14:41 PM

Workflow 11/22
release failure
prerelease failure
mlmodeldownloader failure

@granluo
Copy link
Owner Author

granluo commented Nov 24, 2020

Nightly Testing Report

Failures are detected in workflow(s)
This issue is generated at 11/24/2020 02:45 AM

Workflow 11/23
instanceid failure
release failure
prerelease
mlmodeldownloader failure

@granluo
Copy link
Owner Author

granluo commented Nov 24, 2020

Nightly Testing Report

Failures are detected in workflow(s)
This issue is generated at 11/24/2020 03:07 AM

Workflow 11/23
instanceid failure
appdistribution
release failure
prerelease
mlmodeldownloader failure

@google-oss-bot
Copy link

google-oss-bot commented Dec 2, 2020

Coverage Report

Affected SDKs

  • FirebaseStorage-ios-FirebaseStorage-Unit-unit.xctest

    SDK overall coverage changed from ? (test1com) to 98.59% (testprco) by ?.

    Click to show coverage changes in 14 files.
    Filename Base (test1com) Head (testprco) Diff
    FIRAuthInteropFake.m ? 80.00% ?
    FIRComponentTestUtilities.m ? 0.00% ?
    FIRStorageComponentTests.m ? 100.00% ?
    FIRStorageDeleteTests.m ? 100.00% ?
    FIRStorageGetMetadataTests.m ? 100.00% ?
    FIRStorageListTests.m ? 100.00% ?
    FIRStorageMetadataTests.m ? 100.00% ?
    FIRStoragePathTests.m ? 100.00% ?
    FIRStorageReferenceTests.m ? 100.00% ?
    FIRStorageTestHelpers.m ? 89.42% ?
    FIRStorageTests.m ? 100.00% ?
    FIRStorageTokenAuthorizerTests.m ? 96.03% ?
    FIRStorageUpdateMetadataTests.m ? 100.00% ?
    FIRStorageUtilsTests.m ? 100.00% ?
  • FirebaseStorage-ios-FirebaseStorage.framework

    SDK overall coverage changed from ? (test1com) to 59.59% (testprco) by ?.

    Click to show coverage changes in 19 files.
    Filename Base (test1com) Head (testprco) Diff
    FIRStorage.m ? 75.30% ?
    FIRStorageComponent.m ? 100.00% ?
    FIRStorageDeleteTask.m ? 98.02% ?
    FIRStorageDownloadTask.m ? 0.00% ?
    FIRStorageErrors.m ? 53.46% ?
    FIRStorageGetDownloadURLTask.m ? 15.43% ?
    FIRStorageGetMetadataTask.m ? 98.52% ?
    FIRStorageListResult.m ? 83.33% ?
    FIRStorageListTask.m ? 98.94% ?
    FIRStorageMetadata.m ? 96.65% ?
    FIRStorageObservableTask.m ? 50.00% ?
    FIRStoragePath.m ? 92.86% ?
    FIRStorageReference.m ? 36.20% ?
    FIRStorageTask.m ? 84.85% ?
    FIRStorageTaskSnapshot.m ? 27.59% ?
    FIRStorageTokenAuthorizer.m ? 100.00% ?
    FIRStorageUpdateMetadataTask.m ? 98.68% ?
    FIRStorageUploadTask.m ? 42.78% ?
    FIRStorageUtils.m ? 100.00% ?

Test Logs

  • Head (testprco): <datelink.>

Notes

asdf dat)

@granluo
Copy link
Owner Author

granluo commented Apr 13, 2021

Coverage Report

Affected SDKs

  • FirebasePerformance-iOS-FirebasePerformance.framework

    SDK overall coverage changed from 88.04% (1dbc0edd) to 87.58% (cbd365cd) by -0.46%.

    Filename Base (1dbc0edd) Head (cbd365cd) Diff
    FPRClient.m 64.57% 57.95% -6.62%

Incremental Code Coverage

The incremental code coverage in this PR is x%

Uncovered Code Lines

FirebasePerformance/Sources/FPRClient.m

166: NSString *plistPath = [[NSBundle mainBundle] pathForResource:@"GoogleService-Info"
167:                                                            ofType:@"plist"];
168:      NSMutableDictionary *googleServiceDict =
169:          [NSMutableDictionary dictionaryWithContentsOfFile:plistPath];
170:
171:     FPRLogDebug(kFPRClientMetricLogged,
172:                  @"Please visit "
173:                  @"https://console.firebase.google.com/project/%@/performance/app/ios:%@/metrics/"
174:                  @"trace/DURATION_TRACE/%@ for more information",
175:                  googleServiceDict[@"PROJECT_ID"], googleServiceDict[@"BUNDLE_ID"], trace.name);
...
202:      NSString *plistPath = [[NSBundle mainBundle] pathForResource:@"GoogleService-Info"
203:                                                            ofType:@"plist"];
204:      NSMutableDictionary *googleServiceDict =
205:          [NSMutableDictionary dictionaryWithContentsOfFile:plistPath];
206:
207:      FPRLogDebug(kFPRClientMetricLogged,
208:                  @"Please visit "
209:                  @"https://console.firebase.google.com/project/%@/performance/app/ios:%@/trends "
210:                  @"for more information",
211:                  googleServiceDict[@"PROJECT_ID"], googleServiceDict[@"BUNDLE_ID"]);

Test Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants