Enable configuring base URL for Anthropic provider#107
Open
windoze wants to merge 4 commits intograniet:mainfrom
Open
Enable configuring base URL for Anthropic provider#107windoze wants to merge 4 commits intograniet:mainfrom
windoze wants to merge 4 commits intograniet:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8076f42356
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This commit fixes two issues that prevented the Anthropic provider from
working correctly in the TUI:
1. Onboarding now sets backend field in provider config
- Previously, providers configured through TUI onboarding defaulted to
OpenAI backend because the `backend` field wasn't being set
- Now automatically sets `backend` field based on selected provider
- Added Display impl for LLMBackend to enable string conversion
2. Filter out empty placeholder messages before sending to API
- TUI creates empty assistant messages as placeholders before streaming
- These empty messages were being sent to Anthropic API, causing
"text content blocks must be non-empty" errors
- Now skips empty messages when converting to ChatMessage format
Fixes issues where:
- CLI worked but TUI failed with Anthropic provider
- Custom base URLs didn't use correct backend
- Empty placeholder messages caused API errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backendfield inconfig.tomlafter onboarding so newly configured provider can be other than OpenAI