feat: implement cheap clone via Arc<Config> for all LLM backends#103
Merged
graniet merged 2 commits intograniet:mainfrom Jan 7, 2026
Merged
Conversation
This change wraps backend configurations in Arc to enable O(1) cloning instead of expensive deep copies. All backend structs now derive Clone. Changes: - Wrap config fields in Arc<*Config> for all backends - Make config structs and fields public for direct access - Make client field public on all backends - Add with_client() constructors for HTTP client injection/pooling - Add doc comments to all config struct fields - Remove redundant accessor methods (use direct field access instead) Backends updated: - Anthropic, Google, Ollama, DeepSeek, XAI, AzureOpenAI, Phind, ElevenLabs - OpenAICompatibleProvider (used by OpenAI, Groq, Mistral, Cohere, OpenRouter, HuggingFace) Breaking changes: - Previously private config fields are now accessed via .config.field - client() getter removed, use .client directly Draft assisted with OpenCode.
Contributor
Author
Owner
|
Thank you @aniketfuryrocks for your work, I will review soon ! |
Owner
|
LGTM ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR wraps backend configurations in
Arcto enable O(1) cloning instead of expensive deep copies. All backend structs now deriveClone.Arc<*Config>for all backendswith_client()constructors for HTTP client injection/poolingBackends Updated
Standalone backends:
OpenAI-compatible backends (via OpenAICompatibleProvider):
Usage
Testing
Draft assisted with OpenCode