Skip to content

add gzip deflation to HtmlFetcher #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kqr wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

add gzip deflation to HtmlFetcher #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3977993
add gzip deflation to HtmlFetcher
christofferagoodid Aug 11, 2015
b975ca0
give mock response Message object headers, according to spec
christofferagoodid Aug 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions goose/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
limitations under the License.
"""
import urllib2
import zlib


class HtmlFetcher(object):
Expand Down Expand Up @@ -56,5 +57,7 @@ def get_html(self, url):

# read the result content
if self.result is not None:
if self.result.info().get('Content-Encoding') == 'gzip':
return zlib.decompress(self.result.read(), zlib.MAX_WBITS | 16)
return self.result.read()
return None
4 changes: 3 additions & 1 deletion tests/extractors/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import urllib2
import unittest
import socket
import mimetools

from StringIO import StringIO

Expand Down Expand Up @@ -53,7 +54,8 @@ def content(self):
def response(self, req):
data = self.content(req)
url = req.get_full_url()
resp = urllib2.addinfourl(StringIO(data), data, url)
headers = mimetools.Message(StringIO(''))
resp = urllib2.addinfourl(StringIO(data), headers, url)
resp.code = self.code
resp.msg = self.msg
return resp
Expand Down