Open
Conversation
mykolas-alt
force-pushed
the
bos-coster-msm
branch
from
820c108 to
d381d85
Compare
ArtiomTr
suggested changes
Dec 10, 2025
Contributor
ArtiomTr
left a comment
ArtiomTr
left a comment
There was a problem hiding this comment.
Please rebase from main branch, and when you finish, squash all your commits into one
mykolas-alt
force-pushed
the
bos-coster-msm
branch
from
bd1fc73 to
d506500
Compare
Author
|
rebased, aligned api with the way arkmsm does it |
mykolas-alt
force-pushed
the
bos-coster-msm
branch
2 times, most recently
from
4ef9c02 to
fc4a2db
Compare
ArtiomTr
suggested changes
Dec 15, 2025
ArtiomTr
reviewed
Dec 15, 2025
mykolas-alt
force-pushed
the
bos-coster-msm
branch
2 times, most recently
from
d013787 to
b7d180b
Compare
ArtiomTr
suggested changes
Dec 17, 2025
Contributor
ArtiomTr
left a comment
ArtiomTr
left a comment
There was a problem hiding this comment.
looks good, but still few changes needed. Also, don't forget to fix CI - kzg crate needs formatting to be fixed, and zkcrypto crate now has some issues with clippy. Those clippy issues would probably resolve after you remove feature checks between bos_coster and bgmw/arkmsm/wbits ones.
mykolas-alt
force-pushed
the
bos-coster-msm
branch
3 times, most recently
from
c0585a4 to
221377a
Compare
pairing heap
mykolas-alt
force-pushed
the
bos-coster-msm
branch
from
221377a to
26c81ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.