EIP-7594 - Seeking feeback on computing roots of unity and finite fields implementations#262
Open
owanikin wants to merge 12 commits intograndinetech:mainfrom
Open
EIP-7594 - Seeking feeback on computing roots of unity and finite fields implementations#262owanikin wants to merge 12 commits intograndinetech:mainfrom
owanikin wants to merge 12 commits intograndinetech:mainfrom
Conversation
owanikin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In implementing compute_cells_and_kzg_proof: ,
There are other functions that I need to implement some of which are compute_roots_of_unity & _fft_finite_fields , which i have implemented and seeking your feedback on if I am on the right track.
Thank you so much