Add engine_forkchoiceUpdatedV4 support for BAL#633
Draft
Add engine_forkchoiceUpdatedV4 support for BAL#633
engine_forkchoiceUpdatedV4 support for BAL#633Conversation
hangleang
force-pushed
the
feature/engine_forkchoice_updated_v4
branch
from
2d92f75 to
b7abfd2
Compare
Collaborator
Author
|
Hey @ArtiomTr, Do I also need to update C# code for nethermind integration? |
Collaborator
yeah probably, as otherwise the grandine-nethermind integration will crash at runtime, when grandine will try to call non-existend method from nethermind. If you want to, you can keep it as-is for now, I'll implement nethermind side later, after this is merged into develop. |
Collaborator
Author
I think I got the pattern, I added the binding at ea62bd1 |
Tumas
reviewed
Mar 13, 2026
Member
|
I think this will have to wait for a new Nethermind release. Otherwise it will brake the build if we merged it as is. /disk/workspace/grandine3/bindings/csharp/Grandine.NethermindPlugin/GrandineUtils.cs(268,13): error CS0117: 'PayloadAttributes' does not contain a definition for 'SlotNumber'
/disk/workspace/grandine3/bindings/csharp/Grandine.NethermindPlugin/GrandineEngineApi.cs(264,58): error CS1061: 'IEngineRpcModule' does not contain a definition for 'engine_forkchoiceUpdatedV4' and no accessible extension method 'engine_forkchoiceUpdatedV4' accepting a first argument of type 'IEngineRpcModule' could be found (are you missing a using directive or an assembly reference?)
|
hangleang
force-pushed
the
feature/engine_forkchoice_updated_v4
branch
from
b1f4c3e to
085cfad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.