Skip to content

fix: duplicate get_attestation_participation_flags for Deneb phase to streamline participation flag logic#54

Open
Kayden-ML wants to merge 1 commit intograndinetech:developfrom
Kayden-ML:helping_function/accessors
Open

fix: duplicate get_attestation_participation_flags for Deneb phase to streamline participation flag logic#54
Kayden-ML wants to merge 1 commit intograndinetech:developfrom
Kayden-ML:helping_function/accessors

Conversation

@Kayden-ML
Copy link
Copy Markdown

Changes Made:

Refactored Functionality: Introduced get_attestation_participation_flags_deneb to handle participation flag logic specific to the Deneb phase. This separation of logic ensures that the Deneb functionality is clearly defined and distinct from earlier phases.

Eliminated Conditional Complexity: By removing the need to check the state phase within the original function, the code is now cleaner and more straightforward. This reduces cognitive overhead when reading and maintaining the code.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 30, 2024

CLA assistant check
All committers have signed the CLA.

@povi
Copy link
Copy Markdown
Collaborator

povi commented Nov 4, 2024

Hi,

Looks like get_active_balance is not used anywhere?

Also, a modified get_attestation_participation_flags_deneb function is called at the end of the original function, so basically the code in original function is executed at runtime without any benefit before a modified one is called.

Finally, it should be deneb::get_attestation_participation_flags and not get_attestation_participation_flags_deneb, same as modified functions in helper_functions are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants