fix: add maximum size validation for JWT secrets to prevent DoS attacks#301
Open
crStiv wants to merge 2 commits intograndinetech:developfrom
Open
fix: add maximum size validation for JWT secrets to prevent DoS attacks#301crStiv wants to merge 2 commits intograndinetech:developfrom
crStiv wants to merge 2 commits intograndinetech:developfrom
Conversation
Member
|
Hey, Thanks for the pull request! A few notes:
Feel free to adjust your pull request or open a new one to enforce an exact 256-bit check for the secret if you prefer. |
Author
|
@Tumas made some changes, hope I implemented everything exactly as you wished it to be done |
Author
|
@Tumas pinging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add maximum size validation for JWT secrets in eth1_api auth module