Draft
Conversation
…aximum size calculations
|
|
7e168fe to
d6fbbf0
Compare
90ae8dd to
bc91290
Compare
bc91290 to
58d5ec9
Compare
0600395 to
8905249
Compare
328f69a to
611d6d4
Compare
611d6d4 to
add9a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some bug fixes for minimum size calculation and a currently broken implementation of maximum size calculation.
The
maximumfield should have a type likeResult<usize, SizeError>orResult<usize, TryFromIntError>.There seem to be size calculation bugs in
eth2_libp2pthat I pointed out elsewhere.