Add broken link checker to deploy preview workflow#1331
Open
Add broken link checker to deploy preview workflow#1331
Conversation
Contributor
Readability report
View metric targets
|
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
💻 Deploy preview available (update deploy preview workflow with broken link check): |
Contributor
|
🔗 Broken links report (Add broken link checker to deploy preview workflow): 2 broken links total. Broken links in files changed in this PR:
All other broken links:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
💻 Deploy preview available (Add broken link checker to deploy preview workflow): |
aac9a5a to
78fb055
Compare
1232727 to
0fce8c4
Compare
6818db7 to
4f123ec
Compare
f744b29 to
95ab516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for https://github.com/grafana/website/issues/29598
This PR adds a broken link job to the deploy preview workflow. It refactors the website build step to upload an artifact which is then used simultaneously to deploy the preview and check links.
Unlike our link checker in the website repo, this replaces muffet with standard Golang HTTP requests. The link check process is:
Todo:
../image-rendering/.