Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmds/rtk/src/commands/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ pub fn extract_manifests(
if !target_filters.is_empty() {
let filters: Vec<regex::Regex> = target_filters
.iter()
.map(|f| regex::Regex::new(f))
.map(|f| regex::RegexBuilder::new(f).case_insensitive(true).build())
.collect::<Result<Vec<_>, _>>()
.context("invalid target filter regex")?;

Expand Down
5 changes: 4 additions & 1 deletion cmds/rtk/src/export.rs
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,10 @@ fn compile_target_patterns(patterns: &[String]) -> Result<Vec<regex::Regex>> {
patterns
.iter()
.map(|p| {
regex::Regex::new(p).map_err(|e| anyhow::anyhow!("Invalid target regex '{}': {}", p, e))
regex::RegexBuilder::new(p)
.case_insensitive(true)
.build()
.map_err(|e| anyhow::anyhow!("Invalid target regex '{}': {}", p, e))
})
.collect()
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: v1
data:
key: value
kind: ConfigMap
metadata:
name: app-config
namespace: default
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"default/ConfigMap-app-config.golden": "main.jsonnet"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"version": 1,
"dependencies": [],
"legacyImports": true
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
// Test environment for case-insensitive --target flag
// Tanka's --target is case insensitive, so "configmap/.*" should match "ConfigMap"

local env = {
apiVersion: 'tanka.dev/v1alpha1',
kind: 'Environment',
metadata: {
name: 'target-filter-case-insensitive-test',
},
spec: {
apiServer: 'https://localhost:6443',
namespace: 'default',
},
data: {
// This should be exported (matches configmap/.* case-insensitively)
'app-config': {
apiVersion: 'v1',
kind: 'ConfigMap',
metadata: {
name: 'app-config',
namespace: 'default',
},
data: {
key: 'value',
},
},
// This should NOT be exported (Deployment doesn't match configmap/.*)
'app-deployment': {
apiVersion: 'apps/v1',
kind: 'Deployment',
metadata: {
name: 'app',
namespace: 'default',
},
spec: {
replicas: 1,
selector: {
matchLabels: { app: 'app' },
},
template: {
metadata: { labels: { app: 'app' } },
spec: {
containers: [{
name: 'main',
image: 'nginx:1.25',
}],
},
},
},
},
},
};

env
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[args]
export = ["--target", "configmap/.*"]