Skip to content

Conversation

@Segflow
Copy link
Contributor

@Segflow Segflow commented Dec 19, 2025

What this PR does

This PR updates the dskit dependency to version v0.0.0-20251218155159-03c38747d0d9 which includes the new LRU cache feature for partition ring shuffle sharding.

Why

The updated dskit version includes PR grafana/dskit#856 which adds optional LRU-based caching to the partition ring shuffle shard cache. This is needed for the DataObj consumer to efficiently manage shard caching with bounded memory usage.

Changes

  • Updated go.mod to use dskit commit 03c38747d0d9584b1f537158f0fa90aabefc5142
  • Updated test files to handle the breaking change in ring.NewPartitionRing() which now returns (ring, error) instead of just ring
  • Updated vendor directory with the new dskit version

Related

@Segflow Segflow requested a review from a team as a code owner December 19, 2025 11:00
@Segflow Segflow merged commit 6d74050 into main Dec 19, 2025
68 checks passed
@Segflow Segflow deleted the meher/update-dskit-for-lru-shard-caching branch December 19, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants