(WIP): Fix memory leak when soft-deleting tenant registries #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #746
Note
Archives and deduplicates counters/histograms/summaries from soft-deleted tenant registries and includes them in aggregations; adds tests and a benchmark.
archivedMetricFamilyMapto store metrics from soft-deleted registries (excludes gauges).AddTenantRegistryandRemoveTenantRegistrynow callarchiveTenantRegistryand remove the registry; keep oldRemoveTenantRegistry_Oldfor reference.deduplicateMetrics,getMetricLabelSignature, andmergeMetricValues(counters/summaries/histograms only).BuildMetricFamiliesPerTenant: include archived metrics as an empty-tenant entry; copyarchivedunder lock to avoid concurrent access.TestSoftRemoveTenantRegistryDeduplicationensuring deduplication and accumulation; gauges not archived.BenchmarkSoftRemoveMemoryLeakto verify bounded memory on tenant churn.Written by Cursor Bugbot for commit 350206f. This will update automatically on new commits. Configure here.