ObserveWithExemplar support other spancontext types #662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Was researching that Tempo no longer exported exemplars and identified the root cause: The dskit server instrumentation to export
request_duration_secondshistogram and exemplars no longer works for apps using the Otel or other (non-jaeger) SDK, because we are only checking forjaeger.SpanContext. This updates it to also support other, including Otel SpanContext and bridgeSpanContextBecause this repo doesn't have a dependency on otel, some work is needed to get the data without access to the underlying types, and a simple interface conversion doesn't seem to be possible.
Therefore this is Draft so we can decide on the approach. It's possible that were is a better method that doesn't use reflection.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]