Skip to content

Client: Fix cue imports#1061

Open
spinillos wants to merge 1 commit intomainfrom
client/fix-cue-imports
Open

Client: Fix cue imports#1061
spinillos wants to merge 1 commit intomainfrom
client/fix-cue-imports

Conversation

@spinillos
Copy link
Copy Markdown
Member

CUEImports option completely ignores the values passed though the client.

This was happening in Typescript generation since its common to import a cue file from a different source. It was generating invalid default values such as common.default() instead of common.defaultMyObject().

@spinillos spinillos self-assigned this Apr 1, 2026
@spinillos spinillos requested a review from a team as a code owner April 1, 2026 14:44
@spinillos spinillos requested review from K-Phoen and amalavet April 1, 2026 14:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Note: the diff show code changes that would be introduced by this PR to the output of the Grafana Foundation SDK codegen pipeline.

See full diff.

🔎 Changes to Grafana Foundation SDK

diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/go/dashboardv2beta1/dashboard_converter_gen.go /tmp/foundation-workspace-current/foundation-sdk/go/dashboardv2beta1/dashboard_converter_gen.go
--- /tmp/foundation-workspace-main/foundation-sdk/go/dashboardv2beta1/dashboard_converter_gen.go	2026-04-01 14:48:26.908410262 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/go/dashboardv2beta1/dashboard_converter_gen.go	2026-04-01 14:47:49.722156594 +0000
@@ -244,6 +244,36 @@
 		buffer.Reset()
 
 	}
+	if input.Elements != nil {
+		for key, value := range input.Elements {
+			if value.PanelKind != nil {
+				buffer.WriteString(`Panel(`)
+				arg0 := fmt.Sprintf("%#v", key)
+				buffer.WriteString(arg0)
+				buffer.WriteString(", ")
+				arg1 := PanelConverter(*value.PanelKind)
+				buffer.WriteString(arg1)
+
+				buffer.WriteString(")")
+
+				calls = append(calls, buffer.String())
+				buffer.Reset()
+			}
+			if value.LibraryPanelKind != nil {
+				buffer.WriteString(`LibraryPanel(`)
+				arg0 := fmt.Sprintf("%#v", key)
+				buffer.WriteString(arg0)
+				buffer.WriteString(", ")
+				arg1 := LibraryPanelConverter(*value.LibraryPanelKind)
+				buffer.WriteString(arg1)
+
+				buffer.WriteString(")")
+
+				calls = append(calls, buffer.String())
+				buffer.Reset()
+			}
+		}
+	}
 	if input.Variables != nil && len(input.Variables) >= 1 {
 		for _, item := range input.Variables {
 			if item.QueryVariableKind != nil {
@@ -333,36 +363,6 @@
 
 				buffer.WriteString(")")
 
-				calls = append(calls, buffer.String())
-				buffer.Reset()
-			}
-		}
-	}
-	if input.Elements != nil {
-		for key, value := range input.Elements {
-			if value.PanelKind != nil {
-				buffer.WriteString(`Panel(`)
-				arg0 := fmt.Sprintf("%#v", key)
-				buffer.WriteString(arg0)
-				buffer.WriteString(", ")
-				arg1 := PanelConverter(*value.PanelKind)
-				buffer.WriteString(arg1)
-
-				buffer.WriteString(")")
-
-				calls = append(calls, buffer.String())
-				buffer.Reset()
-			}
-			if value.LibraryPanelKind != nil {
-				buffer.WriteString(`LibraryPanel(`)
-				arg0 := fmt.Sprintf("%#v", key)
-				buffer.WriteString(arg0)
-				buffer.WriteString(", ")
-				arg1 := LibraryPanelConverter(*value.LibraryPanelKind)
-				buffer.WriteString(arg1)
-
-				buffer.WriteString(")")
-
 				calls = append(calls, buffer.String())
 				buffer.Reset()
 			}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants