Skip to content

Converters: Generate disjunctions always in the same order#1059

Open
spinillos wants to merge 1 commit intomainfrom
converters/fix-disjunction-order-generation
Open

Converters: Generate disjunctions always in the same order#1059
spinillos wants to merge 1 commit intomainfrom
converters/fix-disjunction-order-generation

Conversation

@spinillos
Copy link
Copy Markdown
Member

It fixes the order of the disjunction generation in the converters. It should stop to show a diff in the preview changing the order of the elements.

@spinillos spinillos self-assigned this Apr 1, 2026
@spinillos spinillos requested a review from a team as a code owner April 1, 2026 10:16
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Note: the diff show code changes that would be introduced by this PR to the output of the Grafana Foundation SDK codegen pipeline.

See full diff.

🔎 Changes to Grafana Foundation SDK

diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/go/dashboardv2beta1/dashboard_converter_gen.go /tmp/foundation-workspace-current/foundation-sdk/go/dashboardv2beta1/dashboard_converter_gen.go
--- /tmp/foundation-workspace-main/foundation-sdk/go/dashboardv2beta1/dashboard_converter_gen.go	2026-04-01 10:21:39.846581774 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/go/dashboardv2beta1/dashboard_converter_gen.go	2026-04-01 10:20:58.239485960 +0000
@@ -244,6 +244,36 @@
 		buffer.Reset()
 
 	}
+	if input.Elements != nil {
+		for key, value := range input.Elements {
+			if value.PanelKind != nil {
+				buffer.WriteString(`Panel(`)
+				arg0 := fmt.Sprintf("%#v", key)
+				buffer.WriteString(arg0)
+				buffer.WriteString(", ")
+				arg1 := PanelConverter(*value.PanelKind)
+				buffer.WriteString(arg1)
+
+				buffer.WriteString(")")
+
+				calls = append(calls, buffer.String())
+				buffer.Reset()
+			}
+			if value.LibraryPanelKind != nil {
+				buffer.WriteString(`LibraryPanel(`)
+				arg0 := fmt.Sprintf("%#v", key)
+				buffer.WriteString(arg0)
+				buffer.WriteString(", ")
+				arg1 := LibraryPanelConverter(*value.LibraryPanelKind)
+				buffer.WriteString(arg1)
+
+				buffer.WriteString(")")
+
+				calls = append(calls, buffer.String())
+				buffer.Reset()
+			}
+		}
+	}
 	if input.Variables != nil && len(input.Variables) >= 1 {
 		for _, item := range input.Variables {
 			if item.QueryVariableKind != nil {
@@ -333,36 +363,6 @@
 
 				buffer.WriteString(")")
 
-				calls = append(calls, buffer.String())
-				buffer.Reset()
-			}
-		}
-	}
-	if input.Elements != nil {
-		for key, value := range input.Elements {
-			if value.PanelKind != nil {
-				buffer.WriteString(`Panel(`)
-				arg0 := fmt.Sprintf("%#v", key)
-				buffer.WriteString(arg0)
-				buffer.WriteString(", ")
-				arg1 := PanelConverter(*value.PanelKind)
-				buffer.WriteString(arg1)
-
-				buffer.WriteString(")")
-
-				calls = append(calls, buffer.String())
-				buffer.Reset()
-			}
-			if value.LibraryPanelKind != nil {
-				buffer.WriteString(`LibraryPanel(`)
-				arg0 := fmt.Sprintf("%#v", key)
-				buffer.WriteString(arg0)
-				buffer.WriteString(", ")
-				arg1 := LibraryPanelConverter(*value.LibraryPanelKind)
-				buffer.WriteString(arg1)
-
-				buffer.WriteString(")")
-
 				calls = append(calls, buffer.String())
 				buffer.Reset()
 			}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants