Skip to content

Default to type default#1038

Draft
spinillos wants to merge 2 commits intomainfrom
refactor/defaults
Draft

Default to type default#1038
spinillos wants to merge 2 commits intomainfrom
refactor/defaults

Conversation

@spinillos
Copy link
Copy Markdown
Member

  • It creates a compiler pass to transform a generic default into a typed one.
  • It parses the new TypeDefault instead of generic Default in each langauge.

@spinillos spinillos self-assigned this Mar 16, 2026
@spinillos spinillos requested a review from a team as a code owner March 16, 2026 16:13
@spinillos spinillos marked this pull request as draft March 16, 2026 16:13
@github-actions
Copy link
Copy Markdown

Note: the diff show code changes that would be introduced by this PR to the output of the Grafana Foundation SDK codegen pipeline.

See full diff.

🔎 Changes to Grafana Foundation SDK

diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/typescript/src/heatmap/panelBuilder.gen.ts /tmp/foundation-workspace-current/foundation-sdk/typescript/src/heatmap/panelBuilder.gen.ts
--- /tmp/foundation-workspace-main/foundation-sdk/typescript/src/heatmap/panelBuilder.gen.ts	2026-03-16 16:16:45.546515248 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/typescript/src/heatmap/panelBuilder.gen.ts	2026-03-16 16:16:07.279393764 +0000
@@ -585,9 +585,7 @@
             this.internal.options = heatmap.defaultOptions();
         }
         if (!this.internal.options.legend) {
-            this.internal.options.legend = {
-	show: true,
-};
+            this.internal.options.legend = { show: true, };
         }
         this.internal.options.legend.show = true;
         return this;
@@ -602,9 +600,7 @@
             this.internal.options = heatmap.defaultOptions();
         }
         if (!this.internal.options.legend) {
-            this.internal.options.legend = {
-	show: true,
-};
+            this.internal.options.legend = { show: true, };
         }
         this.internal.options.legend.show = false;
         return this;
@@ -626,9 +622,7 @@
             this.internal.options = heatmap.defaultOptions();
         }
         if (!this.internal.options.exemplars) {
-            this.internal.options.exemplars = {
-	color: "rgba(255,0,255,0.7)",
-};
+            this.internal.options.exemplars = { color: "rgba(255,0,255,0.7)", };
         }
         this.internal.options.exemplars.color = color;
         return this;
diff --new-file --unidirectional-new-file '--color=never' --unified --recursive '--exclude=.git' '--exclude=gradle.properties' '--exclude=pyproject.toml' '--exclude=package.json' '--exclude=*.md' /tmp/foundation-workspace-main/foundation-sdk/typescript/src/table/types.gen.ts /tmp/foundation-workspace-current/foundation-sdk/typescript/src/table/types.gen.ts
--- /tmp/foundation-workspace-main/foundation-sdk/typescript/src/table/types.gen.ts	2026-03-16 16:16:45.550612895 +0000
+++ /tmp/foundation-workspace-current/foundation-sdk/typescript/src/table/types.gen.ts	2026-03-16 16:16:07.283495372 +0000
@@ -22,8 +22,7 @@
 	frameIndex: 0,
 	showHeader: true,
 	showTypeIcons: false,
-	footer: { show: false, reducer: [
-], countRows: false, },
+	footer: { show: false, reducer: null, countRows: false, },
 	cellHeight: common.TableCellHeight.Sm,
 });
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant