perf(loki.secretfilter): Small improvements in redactLine#5994
Open
kleimkuhler wants to merge 3 commits intomainfrom
Open
perf(loki.secretfilter): Small improvements in redactLine#5994kleimkuhler wants to merge 3 commits intomainfrom
redactLine#5994kleimkuhler wants to merge 3 commits intomainfrom
Conversation
Member
Author
|
This will likely conflict with #5970 |
![semgrep-code-grafana[bot]](https://avatars.githubusercontent.com/in/1338681?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kalleep
approved these changes
Apr 7, 2026
We originally opted for SHA1 in large part for speed - the goal with hashing the secret is not to keep it entirely secret, but to efficiently conceal it from all but the most determined attackers. After running benchmarks, sha256 is 2.09% slower, and we're looking for every gain we can take right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Two small performance improvements to the
loki.secretfilterhot path; sha1 -> sha256 for hashing secretsPull Request Details
redactLinefmt.SprintfIssue(s) fixed by this Pull Request
Notes to the Reviewer
PR Checklist