Open
Conversation
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7383868504
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kalleep
commented
Apr 1, 2026
| common.ExpectedLogResult{ | ||
| Labels: map[string]string{ | ||
| "detected_level": "info", | ||
| "filename": "/etc/alloy/logs.txt", |
Contributor
Author
There was a problem hiding this comment.
We can no longer check detected_level as a labels because we now tell loki to categorize our labels, meaning detected_level is not treated as label but a parsed value.
Parsed seems to be similar to structured_metadata but is "metadata" that loki can derive from requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Add a new integration test for
loki-processthat tests severalloki.processstages against different inputs.I tried to mix different kind of parser and stages and draw inspiration from what we have in our docs. Also all the test fixtures are written when test run so that timestamps are not stale and get to old to be ingested into loki.
Issue(s) fixed by this Pull Request
Part of: #4953
Notes to the Reviewer
I added the ability to verify structured metedata. For this to work we have to pass a special header to loki:
X-Loki-Response-Encoding-Flags: categorize-labels. This will change the response so I had to update the json parsing logic for it.PR Checklist