Skip to content

adnan-sujak/LiveDebugging.tsx - auto scroll checkbox fix#4735

Open
adnan-sujak wants to merge 2 commits intografana:mainfrom
adnan-sujak:adnan-sujak/autocomplete-checkbox-fix
Open

adnan-sujak/LiveDebugging.tsx - auto scroll checkbox fix#4735
adnan-sujak wants to merge 2 commits intografana:mainfrom
adnan-sujak:adnan-sujak/autocomplete-checkbox-fix

Conversation

@adnan-sujak
Copy link
Copy Markdown

PR Description

adnan-sujak_autocomplete-checkbox-fix

Lifted the state from the imported file to AutoScroll.tsx, added two more parameters to the AutoScroll function, added styling to LiveDebugging.module.css, added license file. Styled with @grafana/ui

Which issue(s) this PR fixes

Issue 1021

Notes to the Reviewer

I noticed there are no tests existing in the repo for the frontend, do I still need to add it?

PR Checklist

  • CHANGELOG.md updated
  • Tests updated

@adnan-sujak adnan-sujak requested a review from a team as a code owner October 30, 2025 17:54
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 30, 2025

CLA assistant check
All committers have signed the CLA.

@adnan-sujak adnan-sujak changed the title adnan-sujak/LiveDebugging.tsx - autocomplete checkbox fix adnan-sujak/LiveDebugging.tsx - auto scroll checkbox fix Oct 30, 2025
@kalleep
Copy link
Copy Markdown
Contributor

kalleep commented Oct 31, 2025

Hey, thanks for the pr. Could this be fixed in upstream first?

I would prefer for us not to vendor a modified dependency.

@adnan-sujak
Copy link
Copy Markdown
Author

Hey, thanks for the pr. Could this be fixed in upstream first?

I would prefer for us not to vendor a modified dependency.

Hey, I opened a PR in the source repo. Waiting for him to approve and merge, afterwards I will update this PR

@github-actions
Copy link
Copy Markdown
Contributor

This PR has not had any activity in the past 90 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants