Conversation
Collaborator
EvgenyGri
commented
Dec 14, 2021
EvgenyGri
commented
- implemented "rpm" target in Makefile
- implemented IPVS admin interface for linux
khannz
reviewed
Dec 14, 2021
Member
khannz
left a comment
khannz
left a comment
There was a problem hiding this comment.
Мне показалось, что viper как-то в очень извращённой манере использован =)
| @@ -0,0 +1,188 @@ | |||
| package ipvs | |||
Member
There was a problem hiding this comment.
В имени файла случаем не опечатка?
pkg/net/ipvs/adm-interface.go
Outdated
Comment on lines
+24
to
+25
| UpdateVirtualSerer(ctx context.Context, serv VirtualServer, opts ...AdminOption) error | ||
| RemoveVirtualSerer(ctx context.Context, vsKey VirtualServerIdentity, opts ...AdminOption) error |
Member
There was a problem hiding this comment.
В слове Server как-будто опечатка.
khannz
approved these changes
Dec 22, 2021
Member
khannz
left a comment
khannz
left a comment
There was a problem hiding this comment.
шик+блеск
(ну разве что опечатка в имени файла pkg/net/ipvs/lunux-impl.go, но кто прочитать не сможет - вон из профессии, я считаю)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.