Skip to content

Migrate segmentation saving in rebased viewer #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Adithyan-Dinesh-Trenser merged 3 commits into from
Mar 11, 2026
Merged

Migrate segmentation saving in rebased viewer #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e61c7ff
Handled segmentation displaysets in Tag browser filtering
Adithyan-Dinesh-Trenser Feb 27, 2026
8e6d142
Migrates segmentation saving in rebased viewer
Adithyan-Dinesh-Trenser Mar 5, 2026
c0426b5
Merge branch 'nightly' into gradienthealth/handle-segmentation-displa…
Adithyan-Dinesh-Trenser Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions extensions/cornerstone-dicom-seg/src/commandsModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ const commandsModule = ({
// If DisplaySet of the segmentation exists, then over write it.
const displaySet = displaySetService.getDisplaySetByUID(segmentationId);
const defaultDataSource = dataSource ?? extensionManager.getActiveDataSource()[0];
const shouldOverWrite = !!displaySet?.StudyInstanceUID && !!displaySet.SeriesInstanceUID;

let reportName: string,
selectedDataSource: string,
Expand Down Expand Up @@ -263,11 +264,11 @@ const commandsModule = ({
SeriesNumber: series ? undefined : 1 + priorSeriesNumber,
predecessorImageId: series,
// Use Series and SOP instancesUIDs if displaySet of the segmentation already exists.
...(displaySet && {
...(shouldOverWrite && {
SeriesInstanceUID: displaySet.SeriesInstanceUID,
SOPInstanceUID: displaySet.instances[0].SOPInstanceUID,
SOPInstanceUID: displaySet.instances?.[0].SOPInstanceUID,
SeriesNumber: displaySet.SeriesNumber,
Manufacturer: displaySet.instances[0].Manufacturer,
Manufacturer: displaySet.instances?.[0].Manufacturer,
}),
},
};
Expand Down
3 changes: 2 additions & 1 deletion extensions/default/src/Actions/createReportAsync.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ async function createReportAsync({
.getDisplaySetsForSeries(SeriesInstanceUID)
?.find(ds => ds.instances.some(instance => instance.SOPInstanceUID === SOPInstanceUID));

const shouldOverWrite = displaySet && displaySet.Modality === 'SEG';
const shouldOverWrite =
displaySet?.StudyInstanceUID && displaySet.SeriesInstanceUID && displaySet.Modality === 'SEG';

if (!naturalizedReport) {
return;
Expand Down
4 changes: 2 additions & 2 deletions extensions/default/src/commandsModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,10 +654,10 @@ const commandsModule = ({
const deidSeriesUIDs = params.getAll('SeriesInstanceUIDs');

const studyDisplaySets = displaySetService.getDisplaySetsBy(ds =>
deidStudyUIDs.includes(ds.instance.DeidStudyInstanceUID)
deidStudyUIDs.includes(ds.instance?.DeidStudyInstanceUID)
);
const displaySets = studyDisplaySets.filter(
ds => !deidSeriesUIDs.length || deidSeriesUIDs.includes(ds.instance.DeidSeriesInstanceUID)
ds => !deidSeriesUIDs.length || deidSeriesUIDs.includes(ds.instance?.DeidSeriesInstanceUID)
);

// If the series filtered displaysets are empty, then use study filtered displaysets.
Expand Down
Loading