-
Notifications
You must be signed in to change notification settings - Fork 56
[newchem-cpp] cppify interp_table_utils.{h->hpp}
#461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mabruzzo
wants to merge
14
commits into
grackle-project:newchem-cpp
Choose a base branch
from
mabruzzo:ncc/cppify-interp_table_utils
base: newchem-cpp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[newchem-cpp] cppify interp_table_utils.{h->hpp}
#461
mabruzzo
wants to merge
14
commits into
grackle-project:newchem-cpp
from
mabruzzo:ncc/cppify-interp_table_utils
+934
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…InfoEntry This information will only be used after we transcribe `calc_grain_size_increment_1d` (at which point we will remove the corresponding constants from phys_constants.h and can entirely delete the dust_const.def file
…e readability (and add some comments)
I moved them from initialize_dust_yields.cpp where the comments were out of place to dust/grain_species_info.cpp
8435f82 to
0cd4082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed after #428 is merged
This is a really tiny PR. I'm introducing it because it will be very helpful in finishing #447. It did 3 minor things:
interp_table_utils.h->interp_table_utils.hppdelete[]for cleaning up agr_interp_grid_propsinstance in anticipation of a change in [newchem-cpp] introduceGrainMetalInjectPathwaystype #447 (the change probably could have waited until then, but it was small enough to do it now).1gr_interp_grid_propsandgr_interp_gridout ofinitialize_chemistry.cppintointerp_table_utils.hppFootnotes
I'm hesitant to go through and convert change every
malloc/freetonew[]/delete[]involving agr_interp_grid_propsor agr_interp_gridin this PR because I can't remember if I introduced any more instances in pending PRs. Honestly, I don't think I did, but if I'm wrong, debugging a mismatchedmalloc/delete[]would be extremely annoying. ↩