Skip to content

Conversation

@mabruzzo
Copy link
Collaborator

@mabruzzo mabruzzo commented Dec 8, 2025

To be reviewed after #428 is merged

This is a really tiny PR. I'm introducing it because it will be very helpful in finishing #447. It did 3 minor things:

  1. converted interp_table_utils.h -> interp_table_utils.hpp
  2. I added the ability to use delete[] for cleaning up a gr_interp_grid_props instance in anticipation of a change in [newchem-cpp] introduce GrainMetalInjectPathways type #447 (the change probably could have waited until then, but it was small enough to do it now).1
  3. I relocated the function for initializing empty gr_interp_grid_props and gr_interp_grid out of initialize_chemistry.cpp into interp_table_utils.hpp

Footnotes

  1. I'm hesitant to go through and convert change every malloc/free to new[]/delete[] involving a gr_interp_grid_props or a gr_interp_grid in this PR because I can't remember if I introduced any more instances in pending PRs. Honestly, I don't think I did, but if I'm wrong, debugging a mismatched malloc/delete[] would be extremely annoying.

…InfoEntry

This information will only be used after we transcribe
`calc_grain_size_increment_1d` (at which point we will remove the
corresponding constants from phys_constants.h and can entirely delete
the dust_const.def file
I moved them from initialize_dust_yields.cpp where the comments were out
of place to dust/grain_species_info.cpp
@mabruzzo mabruzzo added the refactor internal reorganization or code simplification with no behavior changes label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor internal reorganization or code simplification with no behavior changes

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant