-
Notifications
You must be signed in to change notification settings - Fork 56
[newchem-cpp] cppify initialize_UVbackground_data and initialize_cloudy_data
#454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mabruzzo
wants to merge
17
commits into
grackle-project:newchem-cpp
Choose a base branch
from
mabruzzo:ncc/cppify-h5io
base: newchem-cpp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+519
−496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes a few more changes than I initially wanted
This was spurred on by deprecation warnings included on macOS's implementation of the standard library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
initialize_UVbackground_data.ctoinitialize_UVbackground_data.cppandinitialize_cloudy_data.ctoinitialize_cloudy_data.cpp.The tweaks to the source code are EXTREMELY straightforward and formulaic.
I made 3 significant changes:
std::vectorinside ofinitialize_UVbackground_data. This change was made to replace the use of a gcc compiler extension (andstd::vectorwas the easiest way to replicate the prior behavior)my_rates->UVbackground_table. This is now handled by a function calledgrackle::impl::free_UVBtable(this was done for better modularity and better consistency with other datatypes)initialize_empty_UVBtable_structso that it occurs at the start ofinitialize_UVbackground_data(for reference, we previously calledinitialize_empty_UVBtable_structimmediately before we calledinitialize_UVbackground_data-- this won't change anything about how the codebase actually works)