[newchem-cpp] transcribe of cool1d_cloudy_g #450
+291
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherBignamini
changed the title
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…ub.com/ChristopherBignamini/grackle into newchem-cpp_transcribe_cool1d_cloudy_g
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
This reverts commit ff94f5d.
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mabruzzo
reviewed
Nov 20, 2025
src/clib/cool1d_cloudy_g.cpp
Outdated
Comment on lines
27
to
32
| const double* rhoH, const double* metallicity, const double* logtem, | ||
| double* edot, double comp2, double dom, double zr, int icmbTfloor, | ||
| int iClHeat, int iZscale, long long clGridRank, long long* clGridDim, | ||
| double* clPar1, double* clPar2, double* clPar3, long long* clDataSize, | ||
| double* clCooling, double* clHeating, const gr_mask_type* itmask, | ||
| grackle_field_data* my_fields, IndexRange idx_range) { |
Collaborator
There was a problem hiding this comment.
would you mind making a few simplifications to the signature.
Namely:
- could you replace
long long clGridRank,long long* clGridDim,double* clPar1,double* clPar2,double* clPar3,long long* clDataSize,double* clCooling,double* clHeatingwith a single argument of typecloudy_data?- importantly,
cloudy_dataalready exists, and you are currently loading arguments from it right now
- importantly,
- could you cut
grackle_field_data* my_fieldsfrom the argument list?- AFAICT, we only use
grackle_fields->grid_dimension[0]in this function and I'm pretty confident that in those places we can useidx_range->i_stop
- AFAICT, we only use
mabruzzo
reviewed
Nov 20, 2025
src/clib/cool1d_cloudy_g.cpp
Outdated
Comment on lines
111
to
113
| FORTRAN_NAME(interpolate_1d_g)(&log10tem[i], clGridDim, clPar1, | ||
| dclPar.data(), clDataSize, clCooling, | ||
| &log_cool[i]); |
Collaborator
There was a problem hiding this comment.
Would you mind replacing all occurrences of FORTRAN_NAME(interpolate_...) with the C++ wrappers?
It's worth mentioning that the C++ function signature is slightly different. The most notable change is that the C++ wrapper directly returns the result (rather than modifying a pointer argument)
… we only use grackle_fields->grid_dimension[0] which can be obtained from IdxRange
…ub.com/ChristopherBignamini/grackle into newchem-cpp_transcribe_cool1d_cloudy_g
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.