Update docs, add CHANGELOG.md and cleanup #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinhNguyen-nvm
requested review from
arunsampathkumar-grabtaxi and
vanminh-grabtaxi
as code owners
MinhNguyen-nvm
force-pushed
the
add-changelog
branch
from
4d3aa31 to
3a33dc1
Compare
| } | ||
| ``` | ||
|
|
||
| ### Option 2: Legacy buildscript method |
Contributor
There was a problem hiding this comment.
This content seems repeating?
Contributor
Author
There was a problem hiding this comment.
Yes, I think we can remove this legacy approach from the index.md & readme.md
What do you think?
MinhNguyen-nvm
force-pushed
the
add-changelog
branch
from
3a33dc1 to
b2ce320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Issues Fixed