Skip to content

Conversation

@arunkumar9t2
Copy link
Contributor

@arunkumar9t2 arunkumar9t2 commented Nov 29, 2024

Proposed Changes

  1. Organize code and setup publishing
  2. Renamed module to match expected maven artifact id
  3. Currently publishing code lives as a gradle script, will look into moving into to proper convention plugin later.

license {
name = "The MIT License"
url = "https://github.com/grab/App-Sizer/blob/master/LICENSE"
url = "hvttps://github.com/grab/App-Sizer/blob/master/LICENSE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id = 'MinhNguyen-nvm'
name = "Minh Nguyen"
email = "minhnguyen.gtvt@gmail.com"
email = 'van.minh@grab.com'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we keep my personal email "minhnguyen.gtvt@gmail.com"

@vanminh-grabtaxi vanminh-grabtaxi merged commit 23419fe into grab:master Nov 29, 2024
3 checks passed
@arunkumar9t2 arunkumar9t2 deleted the arun/publishing branch November 29, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants