Skip to content

Try/catch in TaskManager to prevent configuration failure #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshay-grabtaxi merged 1 commit into from
Nov 15, 2025
Merged

Try/catch in TaskManager to prevent configuration failure #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@ build/
# Idea non-crucial project fileS
*.iws
.java-version

# Documentation folder - contains drafts, AI-generated content, and other private content not intended for public repo
docs/
15 changes: 12 additions & 3 deletions sizer-gradle-plugin/src/main/kotlin/com/grab/plugin/sizer/TaskManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,13 @@ internal class TaskManager(
) {
when {
project.isAndroidLibrary -> {
val variant = variantExtractor.findMatchVariant(project)
if (variant is AndroidAppSizeVariant) {
task.dependsOn(variant.baseVariant.assembleProvider)
try {
val variant = variantExtractor.findMatchVariant(project)
if (variant is AndroidAppSizeVariant) {
task.dependsOn(variant.baseVariant.assembleProvider)
}
} catch (e: RuntimeException) {
project.logger.warn("Could not find matching variant for Android library project ${project.name}: ${e.message}")
}
}

Expand All @@ -159,6 +163,11 @@ internal class TaskManager(
project.isKotlinMultiplatform -> {
task.dependsOn(project.tasks.named(KMP_JAR_TASK))
}

else -> {
// Skip unsupported project types to avoid variant extraction errors
project.logger.debug("Skipping variant extraction for unsupported project type: ${project.name}")
}
}

}
Expand Down