Extend submit solution timeout to 1 hour #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaroufim
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're running into the problem where the cli is timing out before the timeout which is defined in https://github.com/gpu-mode/reference-kernels.
Reference Kernels should be the source of truth so on the cli we just need the timeout to be long enough to accommodate for everything + exist. I think extending things for 1 hour should accomplish this.
Testing:
./target/release/popcorn-cli submit --gpu MI300 --leaderboard amd-mixture-of-experts --mode leaderboard submission.pytimed out before the change but not after the change. The submission is the one here https://github.com/gpu-mode/reference-kernels/blob/main/problems/amd/moe/submission.py