Skip to content

tutorial_pydanticAI#376

Open
aver81 wants to merge 15 commits intogpsaggese:masterfrom
aver81:master
Open

tutorial_pydanticAI#376
aver81 wants to merge 15 commits intogpsaggese:masterfrom
aver81:master

Conversation

@aver81
Copy link
Collaborator

@aver81 aver81 commented Mar 11, 2026

No description provided.

@aver81 aver81 self-assigned this Mar 11, 2026
@aver81 aver81 requested a review from gpsaggese March 12, 2026 05:42
@gpsaggese gpsaggese mentioned this pull request Mar 12, 2026
@@ -0,0 +1,565 @@
# %% [markdown]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the dead files

@@ -0,0 +1,22 @@
services:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against a docker compose, but why is it needed?
Can we use our usual docker approach? See class_project/project_template/README.md

@@ -0,0 +1,65 @@
#!/usr/bin/env bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed given the latest class_project/project_template

@@ -0,0 +1,1106 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is jupytext not working here?
There should be python files to make reviewing much easier

"id": "d51e740d",
"metadata": {},
"source": [
"# Table of Contents\n",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this

"metadata": {},
"source": [
"## Installation\n",
"\n",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packages should already be in installed in the container

"source": [
"# Run this cell\n",
"try:\n",
" get_ipython().run_line_magic(\"pip\", \"install -q pydantic-ai pydantic python-dotenv nest_asyncio\")\n",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this

"source": [
"# Run this cell\n",
"import os\n",
"from dotenv import load_dotenv, find_dotenv\n",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run /notebooks.format_rules /notebooks.lint /notebooks.move_to_lib

to clean up the notebook

@github-project-automation github-project-automation bot moved this to Todo in Research Mar 18, 2026
@gpsaggese gpsaggese moved this from Todo to Second round in Research Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Second round

Development

Successfully merging this pull request may close these issues.

2 participants