feat(nx-container): add support for registry option#1084
feat(nx-container): add support for registry option#1084callajd wants to merge 6 commits intogperdomor:mainfrom
Conversation
|
Hi @callajd thank you for you interest in this project and for make this contribution, sadly I can't merge this basically because it's already covered using the tags or images options depending if you use metadata or not... The second reason why I can't merge this it's because we will break the possibility to push to multiples registries which it's also covered with |
|
The problem with the existing solution is that it (whether accidentally or intentionally) shoehorns the registry concept into the distinct concepts of images and tags, which distorts the meanings of images and tags while making valid and common use cases unnecessarily difficult.
See for example Docker's explanation, or Google Cloud's. Based on your comments, I've updated my PR to use 'registries' as a string[] instead of 'registry' as a single string, so this new option supports multi-registry deployment. As before, the setting remains optional so existing users can continue using the same approach for multi-registry deployment without issue. |
I went ahead and put together a small commit to enable a
registryoption:registryis defined, this change simply prefixes eachtagwith the value ofregistryand a/, exactly as the docker docs use 'registry'.All of the existing tests pass but it wasn't clear to me where I would add new tests for this option. Happy to add new tests if you could point me in the right direction.