-
Notifications
You must be signed in to change notification settings - Fork 5
AP-212 Make navigation consistent with the copy #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZahuraB
wants to merge
16
commits into
main
Choose a base branch
from
AP_212_make_nav_consistent_with_body_copy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2468259
made navigation consistent with body copy
ZahuraB 23fb2c2
Added suggested changes
ZahuraB b2688c8
Fixed missing link
ZahuraB 4b6706a
Fixed link
ZahuraB 176892d
Renamed a heading
ZahuraB 25d6315
Fixed links in changelog affected by title change
ZahuraB e1eafea
Deleted repeated slugs in links in changelog
ZahuraB 7dff876
Updated a broken link to a wallet doc
ZahuraB 01d259c
Merge branch 'main' into AP_212_make_nav_consistent_with_body_copy
ZahuraB ea644c2
Another fix to the broken link to the wallet doc.
ZahuraB 1916dbf
Reordered bulleted list, changed a page title and last reviewed date
ZahuraB 6f54fde
Merge branch 'main' into AP_212_make_nav_consistent_with_body_copy
ZahuraB b059767
Changed title of page in changelog
ZahuraB 285ea6f
Changed titles on the changelog
ZahuraB 4ad12e7
Changed lower case c to upper case
ZahuraB e3a7561
Troubleshooting partial link
ZahuraB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
source/before-integrating/use-correct-token-authentication-method.html.md.erb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "consider how to integrate third-party platforms with GOV.UK One Login" is a much better description of what that page is for and we should apply this copy to the title of the page titled "Integrating third-party platforms with GOV.UK One Login" - i think we should make the page title and the copy consistent
before-integrating/integrating-third-party-platform/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we need consistency between the page and the navigation. In this case I feel that changing it to "consider how to integrate third-party platforms" would make the title too long. "Integrating-third-party-platform" front loads the information better which is easier for the reader to scan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZahuraB & @pauldougan - Maybe we can agree on a phrase that suits both locations. I suggest "Consider limitations when integrating with third-party platforms".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might need to discuss this further to avoid using a super long title