AUT-5180: Add international SMS support feature flag#8112
Merged
Conversation
sw-mattw
force-pushed
the
AUT-5180/add-intl-sms-ff
branch
from
995adea to
d13b0d2
Compare
sw-mattw
force-pushed
the
AUT-5180/add-intl-sms-ff
branch
from
d13b0d2 to
70b30f0
Compare
sw-mattw
force-pushed
the
AUT-5180/add-intl-sms-ff
branch
from
70b30f0 to
5712d00
Compare
Handler unit tests already verify the send-limit service is respected regardless of why it blocks. The flag-disabled behaviour is covered at both unit and integration level in the send-limit service itself.
The limit service now rejects for both FF disabled and limit reached, rather than only the latter.
sw-mattw
force-pushed
the
AUT-5180/add-intl-sms-ff
branch
from
5712d00 to
ebe7d7e
Compare
sw-mattw
changed the title
|
mattvot
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
We wish to control international SMS functionality for users with existing international numbers.
This PR adds a feature flag to control international SMS delivery across all environments, across both the frontend-api and account-management-api.
Acceptance test changes to follow separately (AUT-5349).
How to review
auth/parent.yamlandaccount-management/parent.yamlensure the flag defaults as expected.InternationalSmsSendLimitServiceto ensure the feature flag check occurs before rate limit lookups.Testing
Deployed to authdev1, confirmed flag set to true on frontend-api lambdas, ran through intl number journey up to the point of entering an OTP (after the send limit check), set flag to false on all frontend-api lambdas, ran through journey again, confirmed error screen rendered prior to enter OTP screen, confirmed in the logs that the log for the FF check (and failure due to this being false) was present.
Ran through password reset journey, both with flag as true, and then as false. For false case, presented with generic error screen as expected.
Checklist