ATO-2463 add logging for client misconfiguration#8110
Merged
arthurs-gds merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
cearl1
reviewed
Apr 2, 2026
cearl1
force-pushed
the
ATO-2463-log-misconfiguration
branch
2 times, most recently
from
20b5d21 to
64f70c1
Compare
cearl1
previously approved these changes
Apr 2, 2026
cearl1
reviewed
Apr 2, 2026
Louisasa
reviewed
Apr 2, 2026
There is one client that as LoCs which allow it to make identity requests but which has identity verification disabled. Before implementing validation which might cause problems in production we are introducing logging to determine whether any problematic calls are actually being made. Co-authored-by: Craig Earl <craig.earl@digital.cabinet-office.gov.uk>
arthurs-gds
force-pushed
the
ATO-2463-log-misconfiguration
branch
from
64f70c1 to
47c5013
Compare
|
Louisasa
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wider context of change
There is one client that as LoCs which allow it to make identity requests but which has identity verification disabled. Before implementing validation which might cause problems in production we are introducing logging to determine whether any problematic calls are actually being made.
What’s changed
We added logging to the authorize validator to cover the specific case where the client request contains a level of confidence corresponding to an identity journey, but where that client has identity journeys turned off.
Manual testing
Checklist
Lambdas have correct permissions for the resources they're accessing.
Impact on orch and auth mutual dependencies has been checked.
Changes have been made to contract tests or not required.
Changes have been made to the simulator or not required. - these changes will following the logging investigation
Changes have been made to stubs or not required.
Successfully deployed to authdev or not required.
Successfully run Authentication acceptance tests against sandpit or not required.