Rename question step type to reflect the change in the forms-admin API#2027
Merged
stephencdaly merged 3 commits intomainfrom Apr 8, 2026
Merged
Rename question step type to reflect the change in the forms-admin API#2027stephencdaly merged 3 commits intomainfrom
stephencdaly merged 3 commits intomainfrom
Conversation
Forms-admin has been updated to use "question" as the step type instead of "question_page". We don't currently consume this in forms-runner as there is only one step type, but update tests to reflect this change.
This reflects the step type being renamed from "question_page" to "question".
This method seemed to want to be specific that we were getting a step that has a question type. There are currently only question type steps, however, if the step was a different type we would still want to know whether it had been completed. Update the parameter name to just be `step`.
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2027.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
lfdebrux
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/02H0xEqG
govuk-forms/forms-admin#2690 renames the step type returned for question steps from "question_page" to "question. These PRs can be merged in any order as the step type isn't currently consumed.
Things to consider when reviewing