Skip to content

Assign cards to TODO: comments#2026

Merged
DavidBiddle merged 1 commit intomainfrom
assign-cards-to-todo-comments
Apr 8, 2026
Merged

Assign cards to TODO: comments#2026
DavidBiddle merged 1 commit intomainfrom
assign-cards-to-todo-comments

Conversation

@DavidBiddle
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle commented Apr 8, 2026

What problem does this pull request solve?

Trello card: https://trello.com/c/hK0527GN/219-review-todo-comments-and-make-product-cards-for-any-that-are-still-relevant

As part of firebreak work we've reviewed the outstanding TODO: comments in this repo and made tech debt cards for them.

This PR adds references to those tech debt cards in the codebase, so that anyone tackling the TODO tasks in future can easily check the card for additional context.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@DavidBiddle DavidBiddle changed the title Reference Trello cards from TODO comments Assign cards to TODO: comments Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2026.submit.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@DavidBiddle DavidBiddle marked this pull request as ready for review April 8, 2026 09:15
@DavidBiddle DavidBiddle added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit b80c9c4 Apr 8, 2026
6 checks passed
@DavidBiddle DavidBiddle deleted the assign-cards-to-todo-comments branch April 8, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants